Support forum of the software localization tool Sisulizer


.NET, Delphi, ... - Sisulizer Localization Tool Support Home

Get in contact with the makers of Sisulizer.
Our forum is open for all questions around Sisulizer from customers and prospects.
Don't hesitate to register and ask. The Sisulizer team will answer ASAP.

Search     Help Home Sisulizer Website Download
Search by username
Not logged in - Login | Register 

 Moderated by: Sisusupport, Renate.Reinartz, Markus.Kreisel, Ilkka.Salmenius Page:    1  2  Next Page Last Page  
New Topic Reply Printer Friendly
slmake: option to return errorcode > 0 for 'warnings' - Bugs and Quirks in Sisulizer - Technical Support (You need to be registered at the forum to write) - .NET, Delphi, ... - Sisulizer Localization Tool Support
AuthorPost
 Posted: Fri May 15th, 2009 11:06 am
PM Private Upload Quote Reply
daniel
Member
 

Joined: Fri May 15th, 2009
Location:  
Posts: 19
Status: 
Offline
i noticed that the commandline util slmake returns errorcode 0 even when a validate task returns some errors/warnings. it does return an errorcode 1 when for example a file is missing. i'm guessing this is not a bug because validate sees it's output as warnings and not errors.
so here is my request: can an option be added to the validate task to return with an errorcode > 0 when validate encounters something? for example i want to let our automated build fail when validate encounters an ' inconsistent format string' warning.

Back To Top PM Private Upload Quote Reply

 Posted: Fri May 15th, 2009 11:46 am
PM Private Upload Quote Reply
Renate.Reinartz
Administrator


Joined: Sat Apr 8th, 2006
Location: Monschau, Germany
Posts: 56
Status: 
Offline
Hi Daniel,

I am not sure if I got your suggestion right. Currently slmake returns:

0 if there are no error or warning items in the log.
1 if there is at least on error item in the log.
2 if there is at least on warning item in the log.

Do I got it right, that you want slmake to return 2 for a warning given by the validation settings in the slp?

I will cross-check that with R&D.

Best regards,
Renate



____________________
http://www.sisulizer.de - Three simple steps to localize
Back To Top PM Private Upload Quote Reply

 Posted: Fri May 15th, 2009 11:50 am
PM Private Upload Quote Reply
daniel
Member
 

Joined: Fri May 15th, 2009
Location:  
Posts: 19
Status: 
Offline
hi renate,

ah, then it is a bug: even though there are warnings the errorcode is still 0...

Back To Top PM Private Upload Quote Reply

 Posted: Fri May 15th, 2009 11:56 am
PM Private Upload Quote Reply
Renate.Reinartz
Administrator


Joined: Sat Apr 8th, 2006
Location: Monschau, Germany
Posts: 56
Status: 
Offline
Hi Daniel,

I see. I moved the thread to our Bugs and Quirks section. Our R&D will take a closer look next week. Just for the case. Are you using Build 2.0.283?

Best regards,
Renate



____________________
http://www.sisulizer.de - Three simple steps to localize
Back To Top PM Private Upload Quote Reply

 Posted: Fri May 15th, 2009 12:44 pm
PM Private Upload Quote Reply
Sisusupport
Administrator
 

Joined: Sat Apr 8th, 2006
Location: Monschau, Germany
Posts: 2261
Status: 
Offline
SlMake has only two result codes:
0 = no errors
1 = at least one error

So if there is a warning SlMake returns 0.

This is from SlMake's help

SlMake version 2008 (Build 283) Copyrights © 2005-2009 Sisulizer Ltd.
Syntax: SlMake <tasks> project [-q] [-h]
Contain one or more tasks and their options. Possible tasks are:
 add          Add a new source and create a new project if needed
 create       Create localized items. You can also use build instead
 duplicate    Translate duplicate strings
 exchange     Create an exchange package
 export       Export data to a file
 fillpseudo   Fill pseudo translation
 import       Import data to project
 remove       Remove unused items
 removepseudo Remove pseudo translation
 report       Create a report
 scan         Scan project
 translate    Translate strings using translation engines
 validate     Validate original or translated values
If no task is given the create task is performed.
 project      Sisulizer project file (.slp) to be processed
 -q           Quiet mode. Only errors are shown.
 -h           Show detailed help about a task.


Examples:
Show detailed help about the import task
 SlMake import -h


Result code is 0 if successful and 1 if an error occured.

Jaakko



____________________
http://www.sisulizer.com - Three simple steps to localize
Back To Top PM Private Upload Quote Reply

 Posted: Fri May 15th, 2009 01:10 pm
PM Private Upload Quote Reply
daniel
Member
 

Joined: Fri May 15th, 2009
Location:  
Posts: 19
Status: 
Offline
ok, so what renate said in her reply (errorcode 2 if there is at least one warning item in the log) is not true, and my intitial remark about warnings not resulting in an errorcode > 0 is?

then i would like to make a request for that! :-)

Back To Top PM Private Upload Quote Reply

 Posted: Fri May 15th, 2009 01:13 pm
PM Private Upload Quote Reply
Markus.Kreisel
Administrator


Joined: Sat Apr 8th, 2006
Location: Monschau, Germany
Posts: 3150
Status: 
Offline
Hi,

Renate was referencing to:

http://forum.sisulizer.com/view_topic.php?id=787

We are a little bit puzzled ourself in the moment. It seems the return value 2 never materialized :-)

Sorry for the confusion.

Markus



____________________
http://www.sisulizer.com - Three simple steps to localize
Back To Top PM Private Upload Quote Reply

 Posted: Fri May 15th, 2009 01:31 pm
PM Private Upload Quote Reply
Sisusupport
Administrator
 

Joined: Sat Apr 8th, 2006
Location: Monschau, Germany
Posts: 2261
Status: 
Offline
There was an idea to implement 0, 1, 2 codes where 2 would be warning. However it was not implemented. The reason is that 0 and 1 were already taken (0 = OK and 1 = error). Using 2 as warning that is much less severe as 1 that was for errors would be illogical. I would have also broke many build process that we expecting nozero to be an error.

I am open to an ideas that would be possible to pass information about warning.

One choice would be an option (e.g. -w) that would change the result code from (0/1) to (0/1/2) where

0 = no errors and warnings
1 = warnings but no errors
2 = errors and possibly also warnings

Jaakko



____________________
http://www.sisulizer.com - Three simple steps to localize
Back To Top PM Private Upload Quote Reply

 Posted: Tue May 19th, 2009 10:46 am
PM Private Upload Quote Reply
daniel
Member
 

Joined: Fri May 15th, 2009
Location:  
Posts: 19
Status: 
Offline
yes jaakko, that suggestion would work great for me!

Back To Top PM Private Upload Quote Reply

 Posted: Tue May 19th, 2009 05:03 pm
PM Private Upload Quote Reply
Sisusupport
Administrator
 

Joined: Sat Apr 8th, 2006
Location: Monschau, Germany
Posts: 2261
Status: 
Offline
I added -w option to SlMake in build 284.

 -w           Result code is 2 if errors, 1 if warnings and 0 if successful.
              Otherwise result code is 1 if errors and 0 in other cases.


If you want three value error code to be given use -w option.

SlMake scan -w MyProject.slp

Jaakko



____________________
http://www.sisulizer.com - Three simple steps to localize
Back To Top PM Private Upload Quote Reply

 Posted: Wed May 20th, 2009 06:42 am
PM Private Upload Quote Reply
daniel
Member
 

Joined: Fri May 15th, 2009
Location:  
Posts: 19
Status: 
Offline
great stuff, and thumbs up for all your quick replys and implementation.
where/when can i download build 284?

Back To Top PM Private Upload Quote Reply

 Posted: Wed May 20th, 2009 07:07 am
PM Private Upload Quote Reply
Sisusupport
Administrator
 

Joined: Sat Apr 8th, 2006
Location: Monschau, Germany
Posts: 2261
Status: 
Offline
Today or tomorrow.

If you join Sisulizer mailing list

http://www.sisulizer.com/support/mailinglist.shtml

you will be automatically notificated when a new build is ready to be downloaded.

Jaakko



____________________
http://www.sisulizer.com - Three simple steps to localize
Back To Top PM Private Upload Quote Reply

 Posted: Wed May 20th, 2009 08:20 am
PM Private Upload Quote Reply
daniel
Member
 

Joined: Fri May 15th, 2009
Location:  
Posts: 19
Status: 
Offline
ok, will do.

thanks and keep up the good work!

Back To Top PM Private Upload Quote Reply

 Posted: Wed May 27th, 2009 05:29 am
PM Private Upload Quote Reply
daniel
Member
 

Joined: Fri May 15th, 2009
Location:  
Posts: 19
Status: 
Offline
hello again,

just installed setup build 284 and unfortunately it seems that this version does not include slmake.exe...

Back To Top PM Private Upload Quote Reply

 Posted: Wed May 27th, 2009 06:47 am
PM Private Upload Quote Reply
Markus.Kreisel
Administrator


Joined: Sat Apr 8th, 2006
Location: Monschau, Germany
Posts: 3150
Status: 
Offline
You are right. We are working on that.

Markus



____________________
http://www.sisulizer.com - Three simple steps to localize
Back To Top PM Private Upload Quote Reply

 Posted: Wed May 27th, 2009 07:04 am
PM Private Upload Quote Reply
Sisusupport
Administrator
 

Joined: Sat Apr 8th, 2006
Location: Monschau, Germany
Posts: 2261
Status: 
Offline
SlMake data in Sisulizer 284 setup was invalid and setup did not install that. I am currently uploading 285 that has valid SlMake.

Jaakko



____________________
http://www.sisulizer.com - Three simple steps to localize
Back To Top PM Private Upload Quote Reply

 Posted: Wed May 27th, 2009 08:28 am
PM Private Upload Quote Reply
daniel
Member
 

Joined: Fri May 15th, 2009
Location:  
Posts: 19
Status: 
Offline
ok, 285 now indeed includes slmake again. but i still get an errorcode of 0, even though there are warnings (missing translations & inconsistent format string, etc) and the -w option is used:
SLMake validate -w -lang:de;en;fr apc.slp
or
SLMake validate -lang:de;en;fr apc.slp -w

Back To Top PM Private Upload Quote Reply

 Posted: Wed May 27th, 2009 11:30 am
PM Private Upload Quote Reply
Sisusupport
Administrator
 

Joined: Sat Apr 8th, 2006
Location: Monschau, Germany
Posts: 2261
Status: 
Offline
This is because validate command does not return any error code. It is always 0. Current SlMake generates the result code based on the log file. If it contanins errors SlMake returns error code, if log contains warnings SlMake returns warning code.

Validation does not add warnings to log but note level items. This is why returns code is always 0.

I will implement warnigs code for valudation task if there are more than one item.

Jaakko



____________________
http://www.sisulizer.com - Three simple steps to localize
Back To Top PM Private Upload Quote Reply

 Posted: Wed May 27th, 2009 02:06 pm
PM Private Upload Quote Reply
Sisusupport
Administrator
 

Joined: Sat Apr 8th, 2006
Location: Monschau, Germany
Posts: 2261
Status: 
Offline
daniel wrote: SLMake validate -w -lang:de;en;fr apc.slp
or
SLMake validate -lang:de;en;fr apc.slp -w

Options must be before SLP file.

I implemented warning exit code to validate task. The new feature will be in build 286. It will come out sometimes next month.

Jaakko



____________________
http://www.sisulizer.com - Three simple steps to localize
Back To Top PM Private Upload Quote Reply

 Posted: Thu May 28th, 2009 06:28 am
PM Private Upload Quote Reply
daniel
Member
 

Joined: Fri May 15th, 2009
Location:  
Posts: 19
Status: 
Offline
aha, well that explains it...but like i mentioned in my 1st post, i was interested in the warnings of the validate task, so i'll try out #286 as soon as it is released, thanks again.

Back To Top PM Private Upload Quote Reply

Current time is 12:57 am Page:    1  2  Next Page Last Page    
.NET, Delphi, ... - Sisulizer Localization Tool Support > Technical Support (You need to be registered at the forum to write) > Bugs and Quirks in Sisulizer > slmake: option to return errorcode > 0 for 'warnings'



WowUltra modified by Sisulizer Copyright © 2007-18 by Jim Hale - Based on WowBB Copyright © 2003-2006 Aycan Gulez

Impress - Privacy statement

Sisulizer software localization tool - Three simple steps to localize